Update Rules, update schema file, add new test to validate XML#137
Update Rules, update schema file, add new test to validate XML#137mkavulich wants to merge 15 commits intoESCOMP:mainfrom
Conversation
…ames OR nested section elements
…on names to the standard names character set
…precision, add "ddt" as options
This reverts commit 533ef71.
- include "of" as a potential modifier for "medium" - Add bullets on valid type entries, xml validation - Fix some formatting
…s' tables that have been moved to the XML
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for these bug fixes.
I made the new test to validate the XML file a required test for merging.
Can you please update the PR title to indicate that this PR does a little more than just adding a validation of the xml file?
mkavulich
changed the title
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for the updates @mkavulich! I just had a couple of questions.
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.x" |
There was a problem hiding this comment.
Is this section needed? I didn't think xmllint needed Python (but I could be wrong).
There was a problem hiding this comment.
Removed, good catch.
| - ``complex`` | ||
| - ``ddt`` (derived data type) | ||
|
|
||
| #. The standard name dictionary XML file should validate according to the schema file ``standard_names.xsd`` All of the above specifications should be coded into this schema file as is appropriate. |
There was a problem hiding this comment.
I realize I am being a little pedantic, but should this say standard_names_v1_0.xsd? Alternatively, should we rename the actual schema file to just standard_names.xsd? I could see that being ideal as I am not sure we really need schema versioning if we now ensure that the actual XML file is always valid against the schema for every PR.
There was a problem hiding this comment.
Originally I was hoping to rename standard_names_v1_0.xsd to standard_names.xsd in this PR, but it turns out there's a bunch of downstream effects there; all the tests ended up failing, so I just reverted it for time's sake and to avoid bloating the PR. I'll open a separate PR to address this.
5 participants
Description
This PR updates the standard name rules to fix some errors, resolve some omissions, and remove information that was moved elsewhere. It also updates the
xsdschema file to properly account for the existing rules and XML format, and adds a test to validate the XML using the schema file.Rules updates
typeelements, and validating the XML with the schema fileinteger,real,logical,character,complex, orddtin_mediumorof_mediumas appropriateXML/schema updates
typeelement optional and update for new rules as aboveIssues
Resolves #136